Add source to the OperatorRewarded event #3136
Conversation
Signed-off-by: linning <linningde25@gmail.com>
…ith the production runtime Signed-off-by: linning <linningde25@gmail.com>
| at_block_number: Number, | ||
| }, | ||
| XDMProtocolFees, | ||
| #[cfg(any(feature = "std", feature = "runtime-benchmarks"))] |
There was a problem hiding this comment.
It seems like this dummy is only used in tests and benchmarks, so I’m not sure we want it enabled for all std code?
| #[cfg(any(feature = "std", feature = "runtime-benchmarks"))] | |
| #[cfg(any(test, feature = "runtime-benchmarks"))] |
There was a problem hiding this comment.
I considered using test but interestingly it doesn't compile...
There was a problem hiding this comment.
That’s concerning, because I can only see Dummy used inside test and feature = "runtime-benchmarks" in this PR. So #[cfg(any(test, feature = "runtime-benchmarks"))] should be enough to make it compile.
What’s the exact compile error?
Is that something you can check, or would you like me to?
There was a problem hiding this comment.
Oh, I see why this happens. subspace-test-service is compiled as a production binary, not a #![cfg(test)] binary.
We could fix this by adding a new feature to sp-domains, and making the test crates depend on it.
This PR adds source to the
OperatorRewardedevent (e.g. which consensus block the bundle fee comes from) along with a minor fix to the consensus test runtime.Code contributor checklist: